consumer: cleanup RDY handling; fix pausing

nsqio / go-nsq

The official Go package for NSQ

MIT License

2.59k stars 444 forks source link

consumer: cleanup RDY handling; fix pausing #249

Closed mreiferson closed 5 years ago

mreiferson commented 5 years ago

this addresses the issue reported in #222

mreiferson commented 5 years ago

RFR

ploxiln commented 5 years ago

I noticed that rdyRetryMtx and backoffMtx can be plain Mutex instead of RWMutex

ploxiln commented 5 years ago

This is honestly the part of NSQ that I'm least familiar with ... the technical details of how ready-count is "refilled" and such ... I'll keep looking and slowly digesting though :)

mreiferson commented 5 years ago

Addressed comments.

the technical details of how ready-count is "refilled" and such

Yea, this is just old and outdated code that's already been addressed in pynsq. See https://github.com/nsqio/nsq/pull/404 for relevant context.

ploxiln commented 5 years ago

looks good 👍