Closed neezhe closed 4 years ago
If you would like to propose a change, it is much easier to read it in context if you open a pull request.
This logic is the trickiest in nsq consumer libraries, so I do not know, without digging in quite a bit, whether this is appropriate or not. So it will be a while until you get a proper reply.
The change looks like it is specifically looking to "optimize" for a case where a connection already has a non-zero rdyCount. But for this loop, that doesn't make sense, if anything you'd want a connection where rdyCount == 0
.
Thanks for the suggestion, but I'm going to close this.
how about this ?
change
into