search

nsqio / nsq

A realtime distributed messaging platform
https://nsq.io
MIT License
24.96k stars 2.9k forks source link

nsqd: Ability to configure ServerName to tlsConfig or update tlsConfig #1337

Closed zereraz closed 3 years ago

zereraz commented 3 years ago

Hi I'm using mTLS(require-verify) with nsqd, issue is not being able to set ServerName which defaults to localhost which won't be on my certificate Subject. https://github.com/nsqio/nsq/blob/a1da1173d3bfa0ea41b73a3b75ec447a32287c52/nsqd/nsqd.go#L716-L721 One way could be nsqd/options.go for ServerName in here or could expose TlsConfig.

zereraz commented 3 years ago

It started to work for me, so closing for now I guess it was wrong assumption.