search

nsqio / nsq

A realtime distributed messaging platform
https://nsq.io
MIT License
24.72k stars 2.89k forks source link

nsqd: concurrency safety #1445

Closed gueFDF closed 1 year ago

gueFDF commented 1 year ago

Should be placed in the critical section for access.

mreiferson commented 1 year ago

Thanks for this. Can you please update this PR to just fix the issue you found in https://github.com/nsqio/nsq/pull/1445/commits/cfbd287826cd2182c28ef7071e62e3a5c98f72ce? We can discuss https://github.com/nsqio/nsq/pull/1445/commits/34f2e70f0c9a84690400a7fd098f1d5c898b2442 separately.

gueFDF commented 1 year ago

谢谢你。您能否更新此 PR 以仅修复您在cfbd287中发现的问题？我们可以单独讨论34f2e70。

Ok I did that.