search

nsqio / nsq

A realtime distributed messaging platform
https://nsq.io
MIT License
24.9k stars 2.9k forks source link

nsqd: arbitrary 1 hour limit for REQ timeout #348

Closed AlekSi closed 10 years ago

AlekSi commented 10 years ago

May it be increased?

mreiferson commented 10 years ago

Chosen arbitrarily :grin:

I would be amenable to a pull request that made it configurable.

tj commented 10 years ago

personally I wouldn't mind seeing the upper limits removed completely, but I can see how they would be handy for typos :D

mreiferson commented 10 years ago

I like the idea of things being bounded (where possible), but configurable. This was just an oversight and I'm fine with making it configurable.

I think it's always better if the user chooses a higher limit for something while packaged with a sane but opinionated default.

mreiferson commented 10 years ago

see #352

AlekSi commented 10 years ago

@mreiferson We (I and @AlphaB) would be very grateful if you make a next patch release with this fix.

mreiferson commented 10 years ago

@AlekSi definitely, we're figuring out what we want in the next release... soon :grin:

AlekSi commented 10 years ago

@mreiferson I mean, if you are going to make a big release, please make a small one with this one small sweet fix before, it will make our life a lot easier.

mreiferson commented 10 years ago

@AlekSi duly noted. I'm not sure I even want to know why you want to requeue things for more than an hour though! :smile:

AlekSi commented 10 years ago

As workaround for #293 (support deferred PUB).

liaojianqi commented 5 years ago

@mreiferson Execuse me, but would you mind to explain why one hour is a "a sane default"?

jehiah commented 5 years ago

@liaojianqi the use-case nsq targets is a "A realtime distributed messaging platform".

p.s. please use forums other than 5 year old closed issues to discuss details of nsq.