search

nss-day-cohort-22 / movie-history-unaccountable-baboons

movie-history-unaccountable-baboons created by GitHub Classroom
2 stars 2 forks source link

Set html #8

Closed eagobert-zz closed 6 years ago

eagobert-zz commented 6 years ago

Pull request to review basic html for site:

  1. git fetch
  2. git checkout branch setHtml
  3. check to make sure all the sections are included for project
  4. click the star ratings to see if they are working. (note: my browserify wasn't bundling).
  5. the star ratings should change to tomato red on click (again browserify wasn't bundling so I couldn't get this to work)
rmbw74 commented 6 years ago

I could see the HTML, but the star ratings were not working.

eagobert-zz commented 6 years ago

Ok. So it was the gruntfile uglify error as discussed. can you fetch again and re-review?

lissagoforth commented 6 years ago

👍