nss-evening-cohort-13 / star-destroyer-dashboard-star-destroyer-dashboard

star-destroyer-dashboard-star-destroyer-dashboard created by GitHub Classroom
0 stars 3 forks source link

Milestone 5: CRUD Operations for Star Destroyer Enemies #84

Closed willkotheimer closed 3 years ago

willkotheimer commented 3 years ago

This is our 5th milestone

Description

Related Issue

https://github.com/nss-evening-cohort-13/star-destroyer-dashboard-star-destroyer-dashboard/issues/39

Motivation and Context

Completes 5th Milestone

How Can This Be Tested?

git fetch origin development git checkout development npm start

https://star-destroyer-a0766.web.app

Screenshots (if appropriate):

Types of changes

brownabs commented 3 years ago

I need the site link

willkotheimer commented 3 years ago

https://star-destroyer-a0766.web.app

brownabs commented 3 years ago

I am seeing some changes that need to be made. Can you create a separate pull request for the readMe and I will approve?

brownabs commented 3 years ago

When trying to add an enemy, if I do not fill out all fields, it does not throw me an error. The edit button is not working for all the cards. When I click on Princess Leia, I do not see an edit form.

willkotheimer commented 3 years ago

We didn't see any bugs. What do you mean by a separate PR for the Readme. It's already merged, and has been PR'd by Jordan.

brownabs commented 3 years ago

Sorry separate milestone so I can approve it being merged into main

brownabs commented 3 years ago

We didn't see any bugs. What do you mean by a separate PR for the Readme. It's already merged, and has been PR'd by Jordan.

^^ see above

HunterJuneau commented 3 years ago

We're not seeing those bugs, are you on the deployed site?