nss-lean-anteaters / nutshell

2 stars 0 forks source link

login user form #31

Closed Deanna2000 closed 6 years ago

Deanna2000 commented 6 years ago

Link to Ticket

Closes # [https://github.com/nss-lean-anteaters/nutshell/issues/30]()

Description of Proposed Changes

Steps to Test

Outline the steps to test

git fetch --all
git checkout dv-login-view
code .
  1. check grunt on src
  2. open hs-o on dist
  3. click on "login" button
  4. The body of the DOM should be cleared (Ronnie's name will disappear)
  5. A form should be added for Username and email and "login" button
  6. Add information for username and email and click "comp reg" button - should see console log of those values
  7. Add info for username and put nothing in email field and click "login" button - should see console log of email and an alert telling you to fill in both fields (you can try with the email field blank as well)

Impacted Areas in Application

List general components of the application that this PR will affect:

Mentions @username

Tag users that need to review this code

Definition of Done

  1. The project must be fully documented. This includes the following:
    1. Complete README that documents the steps to install the code, how to install any dependencies, or system configuration needed.
    2. Every class must be documented with purpose, author, and methods.
    3. Every method must be documented with purpose and argument list - which itself must contain a short purpose for each argument.
  2. The project must be able to run fully, and without errors, on each teammate's system.
  3. Fulfills every requirement. Every line of code has been peer reviewed.
  4. For projects that require unit testing, core functionality must be identified and have at least one test for each.
hayleylandsberg commented 6 years ago

👍 Looks good. Might suggest that we have the main div (id = "holder") that contains the three lanes hidden until they log in / register.

Deanna2000 commented 6 years ago

@obscure-shadow I made some changes and fixed merge conflicts with my local and github branches. Can you please try it again?

obscure-shadow commented 6 years ago

:shipit: