search

nst / RuntimeBrowser

Objective-C Runtime Browser, for Mac OS X and iOS
3.55k stars 510 forks source link

Made a few enhancements to the iOS app for modernization #15

Closed MosheBerman closed 8 years ago

MosheBerman commented 8 years ago

Hey,

I adopted the Main.storyboard as the launch storyboard to enable full resolution on iPhone 6(s) (Plus) and fixed a few "incorrect format for argument" warnings.

I wasn't sure how to handle the retain cycles that the compiler is warning about, because weakSelf is rejected with an error about race conditions, and it felt wrong to do something like this:

  __weak GCDWebServerConnection *weakSelf = self;
  GCDWebServerConnection *strongSelf = weakSelf;

Also, there's one #todo warning in RTBTreeTVC.m that didn't have enough context to fix. So I left them.

MosheBerman commented 8 years ago

Added a fix for issue #14.

nst commented 8 years ago

Good PR! Can you please fix this https://github.com/MosheBerman/RuntimeBrowser/commit/67efb597431ac9d3e0a8b896a46fbc28647e3e9a#commitcomment-15814403 so that I can merge? Thank you.

MosheBerman commented 8 years ago

Fix the formatting of address of o?