nst / STHTTPRequest

Obj-C / Cocoa HTTP requests for humans
BSD 3-Clause "New" or "Revised" License
826 stars 75 forks source link

Digest Authentication #5

Closed alistairg closed 11 years ago

alistairg commented 11 years ago

I added Digest Authentication support, and the ability to set request-specific timeout and method.

Awesome code - thankyou! :)

nst commented 11 years ago

Hello,

I can see two issues in this code:

1) in case of wrong authentication, the server will keep on responding 401 and STHTTPRequest will keep on providing the wrong credentials, endlessly 2) I am not sure we should let the user set requestMethod, since it is automatically decided (GET or POST) according to POSTDictionary existence

I will merge the code and try to improve it.

Thank you for contributing, and don't hesitate to do it again.

nst commented 11 years ago

Note that you can use the following test pages:

TEST Basic Authentication http://ericasadun.com/Private PrivateAccess / tuR7!mZ#eh

TEST Digest Authentication http://jigsaw.w3.org/HTTP/Digest/ guest / guest