search

nstack-io / nstack-ios-sdk

MIT License
5 stars 10 forks source link

Using SKLocalizations type instead of Localizations as LocalizationModel crashes the SDK #66

Closed jakobmygind closed 3 years ago

jakobmygind commented 4 years ago

I don't know if it is supposed to be used for translations, but if not it would be nice to add to the documentation, as I was hunting this crash for a while before it occurred to me to use the other type

So this works: 

 let config = NStackSDK.Configuration(appId: "xx", restAPIKey: "xx", localizationClass: Localizations.self, environment: .debug)

This crashes

 let config = NStackSDK.Configuration(appId: "xx", restAPIKey: "xx", localizationClass: SKLocalizations.self, environment: .debug)
mariusc commented 3 years ago

Yeah, we need to update and improve the documentation; currently, the most relevant one we have is probably in the release notes for the 5.0 version, where no one can find it 🙈

jakobmygind commented 3 years ago

Yeah, we need to update and improve the documentation; currently, the most relevant one we have is probably in the release notes for the 5.0 version, where no one can find it 🙈

Thanks, @mariusc !