search

nstanger / process_podcast

Python script for processing and assembling a podcast from various input sources
0 stars 0 forks source link

[CLOSED] process_podcast: refactor temp file generation for video segments #22

Closed nstanger closed 8 years ago

nstanger commented 8 years ago

Issue by nstanger Tuesday Aug 30, 2016 at 02:29 GMT Originally opened as https://github.com/Otago-InfoSci-Database/Tools/issues/22

Currently there’s both generate_temp_file() and generate_frame(), which do much the same thing. We don’t need these for audio, so perhaps just refactor them into VideoSegment.generate_frame()?

nstanger commented 8 years ago

Comment by nstanger Thursday Sep 01, 2016 at 23:54 GMT

This needs more work than I initially thought. The differences between generate_temp_file() and generate_frame() are probably significant enough for them to remain separate, but there’s a lot of shared code there that could be factored out. For example, generating the temporary file name. Refactoring that requires the output filename, perhaps that should become an instance variable of Segment?