search

nstanger / process_podcast

Python script for processing and assembling a podcast from various input sources
0 stars 0 forks source link

Add unit tests #31

Closed nstanger closed 6 years ago

nstanger commented 6 years ago

Sorely needed!

nstanger commented 6 years ago

Tests for ShellCommand don’t appear to be properly isolated? The value of input_options carries over from test_append_input_options to test_prepend_input_options.

nstanger commented 6 years ago

Tests for ShellCommand.run() and ShellCommand.get_output() will need some form of mocking. (Or is this overkill?)

nstanger commented 6 years ago

test_append_concat_filter() appears to be somewhat broken at present. The actual value is coming out different for n == 2.

Also, I’m slightly suspicious of the “null” inserted into the filter stream when n == 1. Double check this is correct.

nstanger commented 6 years ago

The insertion of “null” into the filter stream is correct.