nstarzynski / munki

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Munki 2 - Error when attempting to import icon from Office 2011 #341

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1.Import Office 2011 14.3.0
2.Choose to try to find an icon
3.

What is the expected output? What do you see instead?
Expected to see that either an icon was found or no icon was found.  Instead a 
UnicodeDecodeError is thrown

What version of the Munki tools/InstallOSpkg tools are you using? On what
version of OS X?
munkiimport reposts version 2.0.0.2086
Mac OS 10.9.3
Please provide any additional information below.
Full error message : 

Traceback (most recent call last):
  File "/usr/local/munki/munkiimport", line 1024, in <module>
    main()
  File "/usr/local/munki/munkiimport", line 972, in main
    generate_pngs_from_installer_pkg(installer_item, pkginfo)
  File "/usr/local/munki/munkiimport", line 300, in generate_pngs_from_installer_pkg
    icon_paths = iconutils.extractAppIconsFromFlatPkg(pkg_path)
  File "/usr/local/munki/munkilib/iconutils.py", line 132, in extractAppIconsFromFlatPkg
    if line.endswith(u'.app/Contents/Info.plist')]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xcc in position 74: 
ordinal not in range(128)

Original issue reported on code.google.com by VEMil...@gmail.com on 27 Jun 2014 at 3:27

GoogleCodeExporter commented 8 years ago
I don't have access to that same installer, so I can't test this myself, but 
try 2.0.0.2090. It's available here:
https://munkibuilds.org/2.0.0.2090/, or you can build from source: 
https://code.google.com/p/munki/wiki/BuildingMunki2Pkgs

Original comment by gregnea...@mac.com on 27 Jun 2014 at 5:46

GoogleCodeExporter commented 8 years ago
Tested with the new build and the import now completes without throwing an 
exception.

Original comment by VEMil...@gmail.com on 27 Jun 2014 at 6:05

GoogleCodeExporter commented 8 years ago

Original comment by gregnea...@mac.com on 27 Jun 2014 at 6:08