search

nstarzynski / munki

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Munki2 fails to download icons for items with periods in name #354

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
With the current Munki 2 icons for items that contain a period in their munki 
name e.g. "AdobeDreamweaver5.5" will not download due to os.path.splitext() 
stripping the ".5" part and causing the download_icons() function to request 
the icon as follows: http://munkirepo/icons/AdobeDreamweaver5 - this causes a 
404 from the repo since the actual icon file is named 
"AdobeDreamweaver5.5.png". I have implemented a patch of updatecheck.py and 
MunkiItems.py on my end that resolves the issue.

https://code.google.com/r/bruienne-munki/source/detail?r=8e1349fbbc1c354f620300f
8e8d63f918b1cc114&name=Munki2

https://code.google.com/r/bruienne-munki/source/detail?r=38c65dad2ea9027b1c33b2a
7cfbee19f8e65f975&name=Munki2

Please review and merge if deemed acceptable.

Original issue reported on code.google.com by bruie...@gmail.com on 22 Jul 2014 at 7:22

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Can you grant me the ability to make code reviews (or add comments; whichever 
the terminology is)?

Original comment by gregnea...@mac.com on 22 Jul 2014 at 8:44

GoogleCodeExporter commented 8 years ago 
Sorry about the separate commits, I re-did the clone and have one commit for 
all changes here:

https://code.google.com/r/bruienne-munkidev/source/detail?r=5fda4c3afce8ff48235c
324dd8362c94ab6a1e5f&name=Munki2

Code review should also be enabled there.

Thanks.

Original comment by bruie...@gmail.com on 23 Jul 2014 at 1:34

GoogleCodeExporter commented 8 years ago 
Thanks for the combined commit (not a big deal, just confused me initially) but 
I still can't seem to comment on lines of code.

Original comment by gregnea...@mac.com on 23 Jul 2014 at 2:13

GoogleCodeExporter commented 8 years ago 
Should be good now, it didn't save the setting for whatever reason.

Original comment by bruie...@gmail.com on 23 Jul 2014 at 2:14

GoogleCodeExporter commented 8 years ago 
Since you seem to have been busy this week, I've pulled your changes, but will 
make further revisions before pushing to the main Munki2 branch.

Original comment by gregnea...@mac.com on 25 Jul 2014 at 9:41

GoogleCodeExporter commented 8 years ago 
Here's my changes to your changes: 
https://code.google.com/p/munki/source/detail?r=fd85f4ef5cfe80266e967684f9aa46dc
57b53bd3&name=Munki2

Original comment by gregnea...@mac.com on 25 Jul 2014 at 10:18