search

nstarzynski / munki

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Munki 2.0.0.2108 - If item does not have a description, there is no error added to failed install #357

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. See issue 356
2. Remove description from main item

What is the expected output? What do you see instead?

The message "Can't install X because could not resolve all dependencies." 
should be shown even if there isn't a description in the pkginfo.

Original issue reported on code.google.com by eriknico...@gmail.com on 1 Aug 2014 at 12:55

GoogleCodeExporter commented 8 years ago 
What am I missing here?
https://code.google.com/p/munki/source/browse/code/apps/Managed%20Software%20Cen
ter/Managed%20Software%20Center/MunkiItems.py?name=Munki2#909

I don't see a code path that would result in the message not being shown if the 
description is empty.

Original comment by gregnea...@mac.com on 1 Aug 2014 at 1:19

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Okay the logs told me what actually happened.

I was playing around with the SelfServiceManifest and munki ran in --auto mode 
right after I removed it. I didn't notice what was happening as I was writing 
up the initial enhancement.

Apologies for the waste of time.

Original comment by eriknico...@gmail.com on 1 Aug 2014 at 1:49

GoogleCodeExporter commented 8 years ago 
"If "InstallRequiresLogout" is true, MSC will show a "logout required" in the 
updates tab - it's harmless though."

Why would that be unexpected? If  "InstallRequiresLogout" is true, MSC should 
tell you that a logout is required. Because a logout is required. Perhaps I'm 
missing something.

Original comment by gregnea...@mac.com on 1 Aug 2014 at 1:51

GoogleCodeExporter commented 8 years ago 
Because the item was actually unavailable due to the dependency issue.

Original comment by eriknico...@gmail.com on 1 Aug 2014 at 1:54

GoogleCodeExporter commented 8 years ago 
You end up with this.

Original comment by eriknico...@gmail.com on 1 Aug 2014 at 1:56

Attachments:

GoogleCodeExporter commented 8 years ago 
Looks to me like if  "InstallRequiresLogout" is true, MSC will _always_ show a 
"logout required" in the updates tab; no connection to dependency errors, etc

Original comment by gregnea...@mac.com on 1 Aug 2014 at 2:08

GoogleCodeExporter commented 8 years ago 
The "Logout required" message issue should be fixed here: 
https://code.google.com/p/munki/source/detail?r=4d4b53ebb025ae400fb103f79cbe577a
58987d4c&name=Munki2; the rest has been determined to not be an actual problem 
(?)

Original comment by gregnea...@mac.com on 1 Aug 2014 at 5:47

GoogleCodeExporter commented 8 years ago 
Well at least 357 wasn't a complete waste of time. Thanks.

Original comment by eriknico...@gmail.com on 1 Aug 2014 at 2:29