Broken remote addon support with V2 of Zoom Moodle plugin

[rlorenzo]

We recently upgraded our Zoom plugin to support the latest V2 of the Zoom API: https://github.com/ucla/moodle-mod_zoom

But found in testing that the Moodle mobile support is now broken. You contributed the patch here: https://github.com/ucla/moodle-mod_zoom/pull/19 and we were wondering if you can help us with a patch.

[nstefanski]

Hi Rex,

I'd be happy to help update the plugin. At the moment, I'm swamped preparing to assist moving our corporate office in two weeks, but I'm hoping to have some time to circle back to this around October 8th. I hope this doesn't have you waiting too long?

If you want to start tinkering yourself sooner, my guess is that any calls to the old API would be in the zipped file - this is essentially a JS addition to the Moodle Mobile app that can be extracted on demand. That's the most guidance I can give without actually digging into the code again.

-Nick

On Thu, Sep 13, 2018 at 12:55 PM Rex Lorenzo notifications@github.com wrote:

We recently upgraded our Zoom plugin to support the latest V2 of the Zoom API: https://github.com/ucla/moodle-mod_zoom

But found in testing that the Moodle mobile support is now broken. You contributed the patch here: ucla/moodle-mod_zoom#19 https://github.com/ucla/moodle-mod_zoom/pull/19 and we were wondering if you can help us with a patch.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiLZzcE0VzytfZmBU6E1NgRHOD4rUks5uapwAgaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

[rlorenzo]

Hello,

That isn't too long.

Thanks for your help!

Rex

On Sep 24, 2018, at 8:01 AM, nstefanski notifications@github.com<mailto:notifications@github.com> wrote:

Hi Rex,

I'd be happy to help update the plugin. At the moment, I'm swamped preparing to assist moving our corporate office in two weeks, but I'm hoping to have some time to circle back to this around October 8th. I hope this doesn't have you waiting too long?

If you want to start tinkering yourself sooner, my guess is that any calls to the old API would be in the zipped file - this is essentially a JS addition to the Moodle Mobile app that can be extracted on demand. That's the most guidance I can give without actually digging into the code again.

-Nick

On Thu, Sep 13, 2018 at 12:55 PM Rex Lorenzo notifications@github.com<mailto:notifications@github.com> wrote:

We recently upgraded our Zoom plugin to support the latest V2 of the Zoom API: https://github.com/ucla/moodle-mod_zoom

But found in testing that the Moodle mobile support is now broken. You contributed the patch here: ucla/moodle-mod_zoom#19 https://github.com/ucla/moodle-mod_zoom/pull/19 and we were wondering if you can help us with a patch.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiLZzcE0VzytfZmBU6E1NgRHOD4rUks5uapwAgaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edumailto:nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-424006001, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAVWRdoe7XOLl-MSNcESdHpRwolmctTBks5uePOygaJpZM4Wn6cX.

[nstefanski]

Hi Rex,

It took me much longer than I thought, but I've finally found some time to circle back to this. I was reviewing the code, and as far as I can tell, none of my code was calling Zoom's API directly, which would have been my first thought. However, I am using some functions from the Zoom module lib.php, so maybe one of those functions I'm using is giving a slightly different return or needs another param, or something similar. I'll try to dedicate some more time next week, I just wanted to let you know that this hasn't been forgotten on our end!

-Nick Stefanski

On Mon, Sep 24, 2018 at 12:59 PM Rex Lorenzo notifications@github.com wrote:

Hello,

That isn't too long.

Thanks for your help!

Rex

On Sep 24, 2018, at 8:01 AM, nstefanski <notifications@github.com<mailto: notifications@github.com>> wrote:

Hi Rex,

I'd be happy to help update the plugin. At the moment, I'm swamped preparing to assist moving our corporate office in two weeks, but I'm hoping to have some time to circle back to this around October 8th. I hope this doesn't have you waiting too long?

If you want to start tinkering yourself sooner, my guess is that any calls to the old API would be in the zipped file - this is essentially a JS addition to the Moodle Mobile app that can be extracted on demand. That's the most guidance I can give without actually digging into the code again.

-Nick

On Thu, Sep 13, 2018 at 12:55 PM Rex Lorenzo <notifications@github.com mailto:notifications@github.com> wrote:

We recently upgraded our Zoom plugin to support the latest V2 of the Zoom API: https://github.com/ucla/moodle-mod_zoom

But found in testing that the Moodle mobile support is now broken. You contributed the patch here: ucla/moodle-mod_zoom#19 https://github.com/ucla/moodle-mod_zoom/pull/19 and we were wondering if you can help us with a patch.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1, or mute the thread < https://github.com/notifications/unsubscribe-auth/ARlyiLZzcE0VzytfZmBU6E1NgRHOD4rUks5uapwAgaJpZM4Wn6cX>

.

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edumailto:nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-424006001>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AAVWRdoe7XOLl-MSNcESdHpRwolmctTBks5uePOygaJpZM4Wn6cX>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-424067544, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiHeH3gJV28-rRkfbiJ-kZ9eTJ1eqks5ueR1jgaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

[nstefanski]

Rex,

I've done some additional testing, and I'm actually able to use the updated plugin without issues in the mobile app. So, I wanted to get some more details on what sorts of issues you're having?

First off, what version of Moodle are you using? My test environment is on version 3.4.3, so I was wondering if you were on version 3.5.X? Looking at the latest documentation for Moodle's Remote Add-Ons, it seems like they may have made some changes that only had an effect starting in 3.5, but I wante to confirm that this is a factor.

Second, can you give me any specific details with what kind of error is occurring? Are you getting a message that the plugin is not supported in the mobile app? Or unable to join the meetings?

Last question, are you using the official Moodle Mobile app, the paid Branded option, or are you maintaining your own version of the mobile app? I ask because we recently launched a branded app maintained by Moodle Pty, and we seem to get an issue with Zoom on the branded app, but not on Moodle's official app. I've recently reached out to Berta Maroto at Moodle about this!

Best regards,

-Nick

On Fri, Nov 16, 2018 at 4:56 PM Nicholas Stefanski nstefanski@escoffier.edu wrote:

Hi Rex,

It took me much longer than I thought, but I've finally found some time to circle back to this. I was reviewing the code, and as far as I can tell, none of my code was calling Zoom's API directly, which would have been my first thought. However, I am using some functions from the Zoom module lib.php, so maybe one of those functions I'm using is giving a slightly different return or needs another param, or something similar. I'll try to dedicate some more time next week, I just wanted to let you know that this hasn't been forgotten on our end!

-Nick Stefanski

On Mon, Sep 24, 2018 at 12:59 PM Rex Lorenzo notifications@github.com wrote:

Hello,

That isn't too long.

Thanks for your help!

Rex

On Sep 24, 2018, at 8:01 AM, nstefanski <notifications@github.com<mailto: notifications@github.com>> wrote:

Hi Rex,

I'd be happy to help update the plugin. At the moment, I'm swamped preparing to assist moving our corporate office in two weeks, but I'm hoping to have some time to circle back to this around October 8th. I hope this doesn't have you waiting too long?

If you want to start tinkering yourself sooner, my guess is that any calls to the old API would be in the zipped file - this is essentially a JS addition to the Moodle Mobile app that can be extracted on demand. That's the most guidance I can give without actually digging into the code again.

-Nick

On Thu, Sep 13, 2018 at 12:55 PM Rex Lorenzo <notifications@github.com mailto:notifications@github.com> wrote:

We recently upgraded our Zoom plugin to support the latest V2 of the Zoom API: https://github.com/ucla/moodle-mod_zoom

But found in testing that the Moodle mobile support is now broken. You contributed the patch here: ucla/moodle-mod_zoom#19 https://github.com/ucla/moodle-mod_zoom/pull/19 and we were wondering if you can help us with a patch.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1, or mute the thread < https://github.com/notifications/unsubscribe-auth/ARlyiLZzcE0VzytfZmBU6E1NgRHOD4rUks5uapwAgaJpZM4Wn6cX>

.

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edumailto:nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-424006001>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AAVWRdoe7XOLl-MSNcESdHpRwolmctTBks5uePOygaJpZM4Wn6cX>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-424067544, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiHeH3gJV28-rRkfbiJ-kZ9eTJ1eqks5ueR1jgaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

[rlorenzo]

I just tested it now and it does work. Before we got a blank screen.

We are using a branded app on 3.4.5.

[nstefanski]

Hi Rex,

After further testing, I discovered that there actually is an issue using the Zoom activity with the mobile app in app versions 3.5+. This is not due to any changes you made with the Zoom API, but rather changes that Moodle made to how the app supports additional plugins. I've already started making the necessary changes following Moodle's documentation here: https://docs.moodle.org/dev/Mobile_support_for_plugins Because of the holidays approaching, I may not have it entirely patched until January, but I'll let you know. Feel free to reach out if you have any questions.

-Nick

On Wed, Nov 28, 2018 at 2:39 PM Rex Lorenzo notifications@github.com wrote:

Closed #1 https://github.com/nstefanski/mma-mod-zoom/issues/1.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1#event-1993535956, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiOu20WSVhJBOJm-TfQdN1PJJ1gWuks5uzvScgaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

[rlorenzo]

@nstefanski Do you know if the change you would make to have the plugin work in Moodle 3.5 would be backward compatible with Moodle 3.4?

[nstefanski]

I'm testing on two different versions of the app, 3.4 and 3.5, and currently 3.4 is still using the old Remote Add-On method, so I think that it will remain compatible with all versions. I'll double check with Juan and see if there's anythign else we need to do to maintain compatability!

On Fri, Dec 14, 2018 at 11:55 AM Rex Lorenzo notifications@github.com wrote:

@nstefanski https://github.com/nstefanski Do you know if the change you would make to have the plugin work in Moodle 3.5 would be backward compatible with Moodle 3.4?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-447402520, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiBrVHF-62OAOOc4PTdOBVrU0hnAJks5u4-YagaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

[nstefanski]

FYI just finished a pull request adding basic 3.5 compatibility, more notes on Github. Happy holidays!

On Fri, Dec 14, 2018 at 12:17 PM Nicholas Stefanski < nstefanski@escoffier.edu> wrote:

I'm testing on two different versions of the app, 3.4 and 3.5, and currently 3.4 is still using the old Remote Add-On method, so I think that it will remain compatible with all versions. I'll double check with Juan and see if there's anythign else we need to do to maintain compatability!

On Fri, Dec 14, 2018 at 11:55 AM Rex Lorenzo notifications@github.com wrote:

@nstefanski https://github.com/nstefanski Do you know if the change you would make to have the plugin work in Moodle 3.5 would be backward compatible with Moodle 3.4?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nstefanski/mma-mod-zoom/issues/1#issuecomment-447402520, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlyiBrVHF-62OAOOc4PTdOBVrU0hnAJks5u4-YagaJpZM4Wn6cX .

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts

--

Nicholas Stefanski LMS Manager nstefanski@staff.escoffier.edu 224.698.2129 d

Auguste Escoffier School of Culinary Arts