nsteinme / steinmetz-et-al-2019

Code accompanying Steinmetz et al., 2019
GNU General Public License v3.0
55 stars 14 forks source link

Mexa64-file ccg #4

Closed michaelhadler closed 4 years ago

michaelhadler commented 4 years ago

Hi,

tried to run ccg_mine from Matlab 2020 on Ubuntu 18.04. Got following Error:

Invalid MEX-file '/home/michael/Documents/MATLAB/spikes-master/analysis/helpers/CCGHeart.mexa64': /home/michael/Documents/MATLAB/spikes-master/analysis/helpers/CCGHeart.mexa64: undefined symbol: mxErrMsgTxt

I didn't look into the mex-file yet (beginner, sorry) but from the looks of it: On one occasion mxErrMsgTxt still needs to be commented out (or deleted altogether) and replaced by mexErrMsgIdAndTxt

Best,

Michael

nsteinme commented 4 years ago

Could you try to replace it with the equivalent files from here? https://github.com/cortex-lab/spikes/tree/master/analysis/helpers

I think those might have been updated? I know I did this once... :)

On Wed, May 20, 2020 at 2:06 AM michaelhadler notifications@github.com wrote:

Hi,

tried to run ccg_mine from Matlab 2020 on Ubuntu 18.04. Got following Error:

Invalid MEX-file '/home/michael/Documents/MATLAB/spikes-master/analysis/helpers/CCGHeart.mexa64': /home/michael/Documents/MATLAB/spikes-master/analysis/helpers/CCGHeart.mexa64: undefined symbol: mxErrMsgTxt

I didn't look into the mex-file yet (beginner, sorry) but from the looks of it: On one occasion mxErrMsgTxt still needs to be commented out (or deleted altogether) and replaced by mexErrMsgIdAndTxt

Best,

Michael

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nsteinme/steinmetz-et-al-2019/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ5IP22D4WZIIMAO2UYPNTRSOMPTANCNFSM4NFXY44A .

michaelhadler commented 4 years ago

Hey, the spikes master is where I got the file from in the first place, I guess I landed on your page from the comment section ^^ What platform did you use it on?

nsteinme commented 4 years ago

Sorry for being slow. Ok I see the problem - the c file is corrected, and it has been re-compiled on mac and windows, but it needs someone to compile it on linux in order to update the .mexa64 version. So you need to compile it, which means called "mex CCGHeart" and following any instructions you get if it doesn't work. I'm going to close the issue here - please open a new issue at the spikes repo if you still have problems. And btw if you want to make a PR to the spikes repo with your new compiled version, I'm sure others would find that helpful. Thanks and good luck -

On Fri, May 22, 2020 at 3:14 PM michaelhadler notifications@github.com wrote:

Hey, the spikes master is where I got the file from in the first place, I guess I landed on your page from the comment section ^^ What platform did you use it on?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nsteinme/steinmetz-et-al-2019/issues/4#issuecomment-632929238, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ5IP4HHJ3B65GKY2K7J3LRS32NVANCNFSM4NFXY44A .