nstilt1 / mofo-repo

Repo for the Mofo Mojo
0 stars 0 forks source link

Changing the mechanics of the envelope follower "amount" knobs #8

Open nstilt1 opened 5 months ago

nstilt1 commented 5 months ago

Currently the "amount" knobs are generally additive. I'll explain their current functionality here, and how it might change in a future version.

Current functionality

The "amount" knobs have a range from 0 to some value (we'll say 10).  

Use case 1

The Resonance knob is set to 5. The Resonance Amount envelope follower knob is set to 0. The direction is set to up.

The envelope has no affect on the resonance while the user is playing their guitar.

Use case 2

The Resonance knob is set to 5. The Resonance Amount envelope follower knob is set to 4. The direction is set to up.

The envelope makes the resonance increase from 5 to 9 (5 + 4) each time a note is played on a guitar.

Use case 2

The Resonance knob is set to 5. The Resonance Amount envelope follower knob is set to 4. The direction is set to down.

The envelope makes the resonance decrease from 9 (5 + 4) to 5 each time a note is played on a guitar.

The change

Option 1

The direction buttons might need to go. The UI is already sophisticated enough as it is, and a simpler approach would be to change the range of the "amount" buttons from 0 to N to -N to N.

With this adjustment, a positive value for the "amount" knob will indicate that the envelope should increase from the parameter's value to paramValue + amount, and if the amount is negative, the envelope will decrease from the parameter's value to paramValue - amount.

Option 2

The direction buttons could remain, but the amount knobs will range from -N to N.

A positive amount would indicate that the envelope should hit a peak at paramValue + amount and have a minimum value of paramValue.

A negative amount would indicate that the envelope should hit a peak at paramValue and have a minimum value of paramValue - amount.

The direction buttons will still control the direction.

Sophistication of the cutoff amount knob

The cutoff amount is a little bit tricky, as it is measured in +0.5 octaves above the cutoff, sort of mimicking some hardware. Getting to higher octaves involves multiplying the frequency by 2, so a negative cutoff amount would require dividing the cutoff frequency, potentially leading to some unexpected behavior.

There is an alternative way to handle the cutoff amount. The unit could be Hz instead of +0.5 octaves. A +Hz unit probably would not be of use, but rather setting the maximum value to a specific frequency might ensure more consistency when adjusting the controls.