nstrayer / cv

My CV built using RMarkdown and the pagedown package.
http://nickstrayer.me/cv/
531 stars 389 forks source link

csv #20

Open zackarno opened 4 years ago

zackarno commented 4 years ago

Hello,

I am not sure if something just went wrong during my installation, but i have noticed two issues withe create_CV_object function:

a.) inside the sample_data folder there is no csv called: entries.csv

b.) the paths to the sample_data csvs appear incorrect. They appear like this: cv$entries_data <- readr::read_csv(paste0(data_location, "entries.csv"), skip = 1) cv$skills <- readr::read_csv(paste0(data_location, "language_skills.csv"), skip = 1) cv$text_blocks <- readr::read_csv(paste0(data_location, "text_blocks.csv"), skip = 1) cv$contact_info <- readr::read_csv(paste0(data_location, "contact_info.csv"), skip = 1)

but I think they are missing a forward slash before the file name

dibbles21 commented 3 years ago

Changing

cv$entries_data <- readr::read_csv(paste0(data_location, "entries.csv"), skip = 1) cv$skills <- readr::read_csv(paste0(data_location, "language_skills.csv"), skip = 1) cv$text_blocks <- readr::read_csv(paste0(data_location, "text_blocks.csv"), skip = 1) cv$contact_info <- readr::read_csv(paste0(data_location, "contact_info.csv"), skip = 1)

to

cv$entries_data <- readr::read_csv(paste0(data_location, "/positions.csv")) cv$skills <- readr::read_csv(paste0(data_location, "/language_skills.csv")) cv$text_blocks <- readr::read_csv(paste0(data_location, "/text_blocks.csv")) cv$contact_info <- readr::read_csv(paste0(data_location, "/contact_info.csv"), skip = 1)

worked for me