search

nstrayer / datadrivencv

R package for building customizable CVs from spreadsheets
http://nickstrayer.me/datadrivencv/
Other
594 stars 178 forks source link

Google sheets template is case sensitive #20

Closed MokeEire closed 4 years ago

MokeEire commented 4 years ago

The Google Sheets template indicates that users should put "current" for their current position. This results in the following error message when running build_network_logo(CV$entries_data):

Error in start:end : NA/NaN argument
In addition: Warning message:
In eval_tidy(xs[[j]], mask) : NAs introduced by coercion

However if you change "current" to "Current", there is no issue. A change to the template, or build_network_logo() would fix this

nstrayer commented 4 years ago

Interesting! Can you try swapping your printing function code the new version in the branch "improved_date_handling"? Specifically these lines. I tried to make this not case sensitive by converting all to lowercase but I probably messed it up.

nstrayer commented 4 years ago

I believe this is fixed in the newest version thanks to #25. Test it out and re-open if the issue persists!

You can update to the newest version without wiping your rmd with

devtools::install_github("nstrayer/datadrivencv")
datadrivencv::use_datadriven_cv(
  full_name = ...
  which_files = c("cv_printing_functions.r")
)
MokeEire commented 4 years ago

Yep certainly seems fixed!