nstrayer / datadrivencv

R package for building customizable CVs from spreadsheets
http://nickstrayer.me/datadrivencv/
Other
594 stars 178 forks source link

Pages get cut off only if network logo is included #37

Open fmmattioni opened 4 years ago

fmmattioni commented 4 years ago

Thank you for the amazing package!

I was recently updating my CV with datadrivencv - I had previously built my CV based on your old template, but still hadn't given a try with the new package. Anyways, and I noticed that if some sections were too long, they would get cut off when knitting.

I guess this is something you were trying to avoid here: https://github.com/nstrayer/datadrivencv/blob/master/inst/templates/cv.Rmd#L142

I noticed, though, that the sections only get cut off if the datadrivencv::build_network_logo(CV$entries_data) is present. If this is excluded, sections are not cut off anymore.

This is probably already a known issue, but I thought it would worth it to warn new users about it. I wonder if the network logo gets isolated in an iframe could solve the issue?