nstudio / nativescript-cardview

:diamonds: :clubs: NativeScript widget for Material Design CardView
MIT License
282 stars 51 forks source link

Unable to build module #39

Closed VladimirMilenko closed 7 years ago

VladimirMilenko commented 7 years ago

After cloning there is no way to build this package, also there is no style/Styler class in tns-core-modules which are installed with TNS.

bradmartin commented 7 years ago

If you clone and path to the demo you should be able to build and run just fine. I tested a week ago on an app and all was normal. If you have specific errors please post those. I'm also not following the styler remark. Sorry. Again if you have any detailed errors post those for us. Thanks

On Sun, Dec 25, 2016, 5:42 PM Vladimir Milenko notifications@github.com wrote:

After cloning there is no way to build this package, also there is no style/Styler class in tns-core-modules which are installed with TNS.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-cardview/issues/39, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhDaaORbgR2IXKukrfdxxLsv_OR0Yks5rLv9YgaJpZM4LVfIC .

VladimirMilenko commented 7 years ago

cardview.android.ts(6,24): error TS2307: Cannot find module 'ui/styling/style'. cardview.android.ts(14,21): error TS2503: Cannot find namespace 'android'. cardview.android.ts(57,17): error TS2503: Cannot find namespace 'android'. cardview.ios.ts(7,24): error TS2307: Cannot find module 'ui/styling/style'. cardview.ios.ts(12,17): error TS2304: Cannot find name 'UIView'.

Here is the error after running tsc.

bradmartin commented 7 years ago

So just typescript errors. You can bypass those a few ways. Simple approach is the noEmitOnError flag in your tsconfig set to false

On Tue, Dec 27, 2016, 10:38 AM Vladimir Milenko notifications@github.com wrote:

cardview.android.ts(6,24): error TS2307: Cannot find module 'ui/styling/style'. cardview.android.ts(14,21): error TS2503: Cannot find namespace 'android'. cardview.android.ts(57,17): error TS2503: Cannot find namespace 'android'. cardview.ios.ts(7,24): error TS2307: Cannot find module 'ui/styling/style'. cardview.ios.ts(12,17): error TS2304: Cannot find name 'UIView'.

Here is the error after running tsc.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-cardview/issues/39#issuecomment-269349682, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhLrpXPIPdw0yyrjq_LHiqVV4ZLaGks5rMT8BgaJpZM4LVfIC .

bradmartin commented 7 years ago

Hey @VladimirMilenko does that help any?

bradmartin commented 7 years ago

All is working now. Let me know if you still have issues. Running from the repo, you need to make sure you transpile the .ts to .executable .js files - you can check the scripts in the package.json for some info or just run tsc assuming you have typescript installed on your machine. Then path to demo app and execute tns build ios (or android) and it should work fine. I just fixed an issue with app.ts that caused a crash different than your original report. Hopefully you're good to go now 😄