search

nstudio / nativescript-cardview

:diamonds: :clubs: NativeScript widget for Material Design CardView
MIT License
282 stars 51 forks source link

Investigate shadowOffset with latest changes for iOS #40

Closed NathanWalker closed 7 years ago

NathanWalker commented 7 years ago

@manijak I would like to release a new version with your integrated changes, however investigating today presented some trouble. I can't get the shadowOffset to change. Currently your implementation ends up with the shadow always being cast upwards? See screenshot. The default state should probably be with a subtle shadow cast 1-2 points to the right and down (definitely not upwards I don't think).

Could you investigate this and push any changes to a PR to fix? Then we can get a new version out with this. Thanks again.

screen shot 2017-01-07 at 1 03 16 pm
manijak commented 7 years ago

@NathanWalker sorry for the late reply, just came back from my vacation.

Yeah, it seems that I messed up the default values for shadowOffset in the .ios.ts file. We just need to add proper values here and it should work.

manijak commented 7 years ago

@NathanWalker Created a new PR for this https://github.com/bradmartin/nativescript-cardview/pull/43

bradmartin commented 7 years ago

1.3.0 published.