search

nstudio / nativescript-cardview

:diamonds: :clubs: NativeScript widget for Material Design CardView
MIT License
282 stars 51 forks source link

Updated default values for iOS and README. #45

Closed manijak closed 7 years ago

manijak commented 7 years ago

Perhaps we should double check that default values are the same for Android & iOS.

bradmartin commented 7 years ago

Been so long since I've worked on this but quickly looking at the android source I don't think I ever set default values. The cardview just had it's defaults, I think Walker added the default stuff for iOS to keep it close to the default android look. Not a bad idea to set defaults for both platforms as long as it's a consistent look with the values for both android and iOS (meaning that radius =2 isn't radically different on the different platforms).

manijak commented 7 years ago

It's ok, I just updated the ones for iOS, made them the same as it was in the readme file. You can updated them if you want. The PR includes the documentation for shadowRadius.