search

nstudio / nativescript-cardview

:diamonds: :clubs: NativeScript widget for Material Design CardView
MIT License
282 stars 51 forks source link

fix(iOS): issue with setters #8

Closed NathanWalker closed 8 years ago

NathanWalker commented 8 years ago

@bradmartin For time being, this disables custom settings for radius with iOS. There have been some issues discovered with the setters. Good news is the default appearance settings for MaterialCardView are adequate for the large majority. I would merge this, bump, and republish to ensure iOS users have a smooth experience with this plugin.

I'll post another PR when/if I can get the setters straightened out.

NathanWalker commented 8 years ago

Of course also remember to run npm run build in the root before publishing though! :)

bradmartin commented 8 years ago

Good reminder :+1: I would have not done that. Added you as collaborator, does that give you enough permissions to manage the project? Does npm allow multiple users to publish? Just in case I'm out of contact and something is needed. If you don't want to do it no worries :+1:

NathanWalker commented 8 years ago

That's a good idea yeah, thanks. npm does allow collaborators, I think with this: https://docs.npmjs.com/cli/access or this: https://docs.npmjs.com/cli/owner

NathanWalker commented 8 years ago

Oh my npm username is: walkerrunpdx

bradmartin commented 8 years ago

Thanks. I'll do that later on :)

On Fri, Feb 26, 2016, 8:07 PM Nathan Walker notifications@github.com wrote:

Oh my npm username is: walkerrunpdx

— Reply to this email directly or view it on GitHub https://github.com/bradmartin/nativescript-cardview/pull/8#issuecomment-189556692 .