search

nswdpc / waratah

NSW Design System integration for Silverstripe websites
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Missing title on iframe element template #35

Open tardinha opened 1 year ago

tardinha commented 1 year ago

Missing title on iframe template.

See: WCAG 2.1 A 2.4.1 Section 508 (2017) A 2.4.1

JamesDPC commented 1 year ago

Is AlternateContent not working ?

tardinha commented 1 year ago

Ahh... AlternateContent populates the title, not the iframe title.

JamesDPC commented 1 year ago

For WCAG conformance, the AlternateContent field should be required.

Apart from a typo, the description of the field is OK: https://github.com/nswdpc/silverstripe-elemental-iframe/blob/master/src/Models/Elements/ElementIframe.php#L451