search

nsynkde / Tilda

A timeline written in VL
MIT License
29 stars 3 forks source link

setTC in KeyframeEditor doesn't trigger the event for SetTC #31

Closed ehenze closed 5 years ago

ehenze commented 5 years ago

So the time changes only locally and isn't distributed over the network

jhnnslmk commented 5 years ago

At the keyframe editor's current state I wouldn't consider this a feature to be implemented. What happens here is that the Previous/Next mechanics for keyframe clips are used to easier jump to keyframes in order to manipulate them, so one doesn't have to tediously set the Playhead to their positions manually.

A planned overhaul of the Keyframe Editing routine (issue #26) will render this feature request unneccessary, as you would just open a Keyframe Clip's editing mode and select Keyframes by clicking on them, without any need to adjust the timecode in order to write to them.

ehenze commented 5 years ago

Well the background is, that if several clients are connected, you want to see the keyframe changes on all of them - and you dont get the exact result if the playhead isn’t moved to the keyframe also there ...

Am 12.08.2019 um 18:57 schrieb jhnnslmk notifications@github.com:

At the keyframe editor's current state I wouldn't consider this a feature to be implemented. What happens here is that the Previous/Next mechanics for keyframe clips are used to easier jump to keyframes in order to manipulate them, so one doesn't have to tediously set the Playhead to their positions manually.

A planned overhaul of the Keyframe Editing routine (issue #26 https://github.com/nsynkde/Tilda/issues/26) will render this feature request unneccessary, as you would just open a Keyframe Clip's editing mode and select Keyframes by clicking on them, without any need to adjust the timecode in order to write to them.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/nsynkde/Tilda/issues/31?email_source=notifications&email_token=AAHGO3X7EZ2TZVYJEIKNFNLQEGI7XA5CNFSM4IK2F6Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4DE7XQ#issuecomment-520507358, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHGO3X5DPOKCYUE6OMKSFLQEGI7XANCNFSM4IK2F6YQ.

jhnnslmk commented 5 years ago

I see, I totally misread your briefing. Still, I argue that this won't be needed anymore. The use case you're describing should be two separated actions.

By doing this as described above you won't have a detached Playhead position on all clients at any time.

  1. You start by having a common TC Position on all clients
  2. You open a keyframe clip and edit a keyframe
  3. You will see the result of the same TC still as it wasn't changed.

Changing the timecode when editing a Keyframe was merely a hack for when there only was a nodebased Editing available, changing the TC mustn't be necessary when editing values.