search

nsz32 / docklike-plugin

A Dock-like Taskbar Plugin for XFCE
GNU General Public License v3.0
326 stars 42 forks source link

Problem with crash #49

Open econejer opened 3 years ago

econejer commented 3 years ago

I'll try to explain this the best i can

Sometimes, for no apparent reason, seems like the plugin crashes, but then it came back on his own and no problem, this is quite snappy and nothing wrong with it. But when this happens, some applications are lost (not all), i use 2 monitors, so i move the lost applications from 1 monitor to the other and then back, and the icon came back to the taskbar (i have the option to only show applications for current display) Is quite strange and don't know where i should look for log information or something.

nsz32 commented 3 years ago

Thanks for this report.

What is you linux config ? Can you please tell me if the crashes happen also when the show only current monitor is disabled ? Try without it for some times please. Can you tell me which user actions from you are triggering the crashes ?

Yeah if the plugin is initialized when multiples windows are already there, it happens it can miss one or two, i need to investigate this also.

TY,

econejer commented 3 years ago

Im using arch, with these packages xfce4-docklike-plugin-git 20200904-1 libxfce4ui 4.14.1-3 xfce4-dev-tools 4.14.0-2 xfce4-panel 4.14.4-1 cairo 1.17.2+25+gaee96d175-1

I'm not sure what triggers the crash tbh, the panel just flickers a little and the icons disappears suddenly Sometimes i miss the flicker and the icons are already gone I'm going to try disabling the option for current monitor

thanks!

TheNiteCoder commented 3 years ago

I have encountered this problem as well, I also am using a multi-monitor setup and I have show only windows on current monitor. It seems to occur sometimes when I minimize the application and try to un-minimize. I have looked at the code and it seems somewhere the mActive variable for the Group class is not getting updated correctly as it tries to minimize the application after I have already minimized. The source of the crash for me is the onButtonRelease().

nsz32 commented 3 years ago

Can you try to retrigger it with only the multi-desktop option enabled ? Does it happen as well ?

I have these two options enabled, but without using them : single screen, single desktop, and got no crashes. I suppose that it involve using and manipulating same app between two screens.

Any step-to-reproduce will greatly help.

econejer commented 3 years ago

I have been using the plugin without the multi-workspaces and multi-display option disabled and haven't seen any crashes for days. So should be related to any of those 2, i really don't use multi workspaces, so i'm going to try to enable multi-display and see if i can figure it out what triggers it.

julien-maurel commented 3 years ago

Hi, I have same issue with multi-display checked. I just change parameters to uncheck multi-display and see if issue continue or not... I have impression that crashes appear more often when one application (eg terminator) has some instances opened on different monitors, but craches stay random.

My config : mint 20, xfce14.4, 3 displays with one instance of docklike on each

xfce4-docklike-plugin:
  Installé : 0.0~git20201210.5e8a9a3-0ppa1~20.04
  Candidat : 0.0~git20201210.5e8a9a3-0ppa1~20.04
 Table de version :
 *** 0.0~git20201210.5e8a9a3-0ppa1~20.04 500
        500 http://ppa.launchpad.net/xubuntu-dev/extras/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status
nsz32 commented 3 years ago

Shame that i haven't any multi-monitor system to debug this.

I have impression that crashes appear more often when one application (eg terminator) has some instances opened on different monitors, but craches stay random.

I think that too.

I can't think the crashes are really random : any actions on window (focus change, display changes, ...) before crashes are welcome and will greatly help.

I don't have the time for some weeks to review the code or investigate deeply on this issue.

julien-maurel commented 3 years ago

I'll try do be attentive to any actions and do some tests next week. I don't know if docklike crashes when message error is dispayed, but generaly error poped when I click on an icon of a running programm that have at least 2 instances on multiple monitors.

julien-maurel commented 3 years ago

I do some tests this morning and finally I can reproduce crash:

Crash appears only with multi-display checked, if uncheck it, there is no crash

econejer commented 3 years ago

can confirm, i did the same and got a crash

nsz32 commented 3 years ago

Nice, will try to solve this this week end. Thanks for this minimal step to reproduce, it will help for sure ! A question : did the third point "minimize moved instance", works either the window is minimized from the title bar or from the plugin ? I'm starting in a new company right now, so I will be very busy at working days for some times.

julien-maurel commented 3 years ago

A question : did the third point "minimize moved instance", works either the window is minimized from the title bar or from the plugin ?

I tried by minimizing from the window title bar

davekeogh commented 3 years ago

Can someone else test this and see if the bug is fixed?

julien-maurel commented 3 years ago

Sorry, on my side, I can't test you change because I can't build this tool, I have an error on during, I don't know why (checking for libwnck-3.0 >= 3.30.0... not found but I have this package in version 3.36)

davekeogh commented 3 years ago

That's my bad. There were some changes I hadn't meant to commit in there. Try building the version in my branch now.

julien-maurel commented 3 years ago

My bad too, I needed to install dev version of some packages... I try your branch, issue still present :(

nsz32 commented 3 years ago

6a5e5e1 😎

davekeogh commented 3 years ago

Thanks. This appears to be fixed on my machine. I can't reproduce the crash anymore.

julien-maurel commented 3 years ago

Hi, seems to be fixed here too, thanks!