search

nsz32 / docklike-plugin

A Dock-like Taskbar Plugin for XFCE
GNU General Public License v3.0
326 stars 42 forks source link

Compilation error #57

Closed m4u9 closed 3 years ago

m4u9 commented 3 years ago

Trying to compile it to make a RPM package for openSUSE but I get the following compilation error:

[   28s] SettingsDialog.cpp: In function 'void SettingsDialog::popup()':
[   28s] SettingsDialog.cpp:42:74: warning: 'void gtk_window_set_wmclass(GtkWindow*, const gchar*, const gchar*)' is deprecated [-Wdeprecated-declarations]
[   28s]    42 |   gtk_window_set_wmclass(GTK_WINDOW(dialog), "xfce4-panel", "xfce4-panel");
[   28s]       |                                                                          ^
[   28s] In file included from /usr/include/gtk-3.0/gtk/gtkdialog.h:32,
[   28s]                  from /usr/include/gtk-3.0/gtk/gtkaboutdialog.h:30,
[   28s]                  from /usr/include/gtk-3.0/gtk/gtk.h:31,
[   28s]                  from SettingsDialog.hpp:10,
[   28s]                  from SettingsDialog.cpp:7:
[   28s] /usr/include/gtk-3.0/gtk/gtkwindow.h:154:12: note: declared here
[   28s]   154 | void       gtk_window_set_wmclass              (GtkWindow           *window,
[   28s]       |            ^~~~~~~~~~~~~~~~~~~~~~
[   28s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/docklike-plugin-0.0+git.65c38ec/src'
[   28s] make: *** [Makefile:480: all-recursive] Error 1
[   28s] error: Bad exit status from /var/tmp/rpm-tmp.OvralQ (%build)
[   28s] 
[   28s] 
[   28s] RPM build errors:
[   28s]     Bad exit status from /var/tmp/rpm-tmp.OvralQ (%build)
[   28s] 
[   28s] m4u9-leap failed "build xfce4-docklike-plugin.spec" at Sun Dec 13 17:28:52 UTC 2020.
[   28s]
nsz32 commented 3 years ago

The spec files is too old and while it remains unchanged from 2 years, the compilation system and the dependencies had evolved. # Its %build and %install sections especially are out-of-date : check the actual compilation instructions (from readme) and try to update the .spec file.

m4u9 commented 3 years ago

I did start from scratch following the readme and all dependencies are up to date: https://build.opensuse.org/package/show/home:mauriziogalli/xfce4-docklike-plugin

m4u9 commented 3 years ago

The problem was actually this: 

[   63s] Wnck.cpp: In function 'GtkWidget* Wnck::buildActionMenu(GroupWindow*, Group*)':
[   63s] Wnck.cpp:264:2: error: control reaches end of non-void function [-Werror=return-type]
[   63s]   264 |  }
[   63s]       |  ^

I have prepared a patch and PR #59