search

nsz32 / docklike-plugin

A Dock-like Taskbar Plugin for XFCE
GNU General Public License v3.0
326 stars 42 forks source link

Ubuntu 18.04 build compatibility patch, closes #52, closes #41 #66

Closed gsantner closed 3 years ago

gsantner commented 3 years ago

This PR adds a patch file which individuals (or CI's) may apply so the project builds fine for Ubuntu 18.04 (or similar) + XFCE 4.12.
At same time, project code etc is not affected and stays "as is" for XFCE 4.14 & i.e. Ubuntu 20.04. 

git remote add gsantner https://github.com/gsantner/docklike-plugin.git && git fetch gsantner
git checkout feature-ubuntu1804-support && git reset --hard gsantner/feature-ubuntu1804-support

To apply run:
git am < contrib/patches/0001-ubuntu-18.04-build-compatibility.patch

gsantner commented 3 years ago

@denisgolius Followed the other steps from readme? have you run autogen? make clean? Not think its any related to this.

gsantner commented 3 years ago

You have not applied the patch. Have you even read the description? This adds the change as a patch file, not as a normal commit - it makes sure it not breaks anything.

I added the command to description how to check out the branch.

nsz32 commented 3 years ago

Thank you !