nt1m / livemarks

Extension that restores RSS Feed Livemarks in Firefox.
https://addons.mozilla.org/firefox/addon/livemarks/
MIT License
227 stars 23 forks source link

Default Folder wont allow folder under "Bookmark Toolbar" #259

Open hollywok opened 4 years ago

hollywok commented 4 years ago

Add-on version Add-on version: 2.8

Describe the bug Under more options of the Livemarks add-on I try to select a Default folder that is in the "Bookmarks Toolbar" folder - i.e I have the Live RSS feeds as a drop down menu off a Folder on the Bookmarks Toolbar. It only shows me a list of Folders at the top level of Bookmarks in Firefox and it is also not the full list at that level.

To Reproduce Steps to reproduce the behavior:

  1. Go to Firefox settings menu, select Add-Ons, select Livemarks, select Options and then More Options and try to select a folder in the Default folder area.
  2. I have a folder under Bookmarks Toolbar called RSS-feeds which I would like as the Default Folder for my RSS feeds. Livemarks does not allow me to traverse the Bookmarks Toolbar folder so I can't select it.
  3. In the past I had added the RSS feeds to another, high level, folder and then copied them from there to the other folder but recently they feeds have stopped updating and now show as broken livemarks - again I can't select a subfolder to assign it to.
  4. Error is no update and broken livemark status

Expected behavior Selecting a subfolder should be acceptable to Livemarks options.

nt1m commented 3 years ago

I'm able to set the default folder to a sub folder fine. I think we do remove the default folders from the broken feeds dialog (I can't remember why), but their subfolders should still be there.

csteury commented 3 years ago

I'm having this issue also. The problem is not setting the default folder to a sub-folder, but rather setting the default folder to any sub-folder on the Bookmarks Toolbar. ie The Bookmarks 'Toolbar' is not a selectable option. But this is exactly where I want to put livemarks that I access all the time. Thanks, cs

btw - this is with Firefox version 87.0

evilpie commented 3 years ago

That's a different issue and basically intended behavior. You can only have one feed per bookmark folder. Some of the built-in default bookmarks folder like Toolbar, Other Bookmarks etc. are intentionally not allowed.

csteury commented 3 years ago

Thanks for the quick response although I don't think I understand your explanation! I also don't think I communicated the problem very well either, so here is a more long-winded description.

This was working as I expected before, but I corrupted my Firefox bookmarks and was forced to create a new profile and load a bookmarks backup file to get my bookmarks back. However this meant I needed to reload my Firefox extensions including LiveMarks. My bookmarks were restored correctly including my previous LiveMarks, which I stored in a sub-folder on the Bookmarks Toolbar called "RSS Feeds". They are stilll getting updated correctly from the RSS feeds but when I attempted to use the same folder for new Livemarks, it would only allow me to a specify a location under "Bookmarks Menu" and Livemarks appeared to have no knowledge of the previously created livemarks (in my original profile)! Here are screenshots I hope illustrate the problem;

  1. Image of previous RSS subfolder on toolbar in old profile
  2. Image of previous Default Folder choices in old profile (which included Bookmarks Toolbar)
  3. Image of current Default Folder choices in new profile under Bookmarks Manager

I hope this makes sense (Images 1, 2 & 3 follow) - Thanks!

Firefox Toolbar - Screenshot 2021-03-26 105259 LiveMarks Options - Desired Behavior - Screenshot 2021-03-26 104831 LiveMarks Expanded Broken - Screenshot 2021-03-26 110727

gozoc commented 3 years ago

I can confirm this error !!! In the config is no folger available (earlier already), which is in the "Bookmark Toolbar". In my toolbar i have the folder "News" ... It used to work. Probably because of a new firefox version...

But, if i create a new folder in "Bookmark Toolbar", is it listed in the pulldown menue. I am confused.

csteury commented 3 years ago

For me this bug was a showstopper. I.e. I created a folder named 'rss' on the toolbar which allowed easy access and organization to my RSS feeds. Now I am unable to access the toolbar or any of its sub-folders, which means that I have to mix my RSS live marks in with the 'regular' bookmarks - which pretty much negates the convenience!

I'm tempted to try and fix it but hesitant due to my lack of experience working on Firefox extensions ...

evilpie commented 3 years ago

I honestly still don't understand the problem fully, but I have a theory: I see that you use your "rss" folder as both the parent of other folders, but also a RSS folder itself? That is not supported and will break thing. You have to change the livemarks that uses the folder for "rss" to something else.

csteury commented 3 years ago

Tom, Tom, Thanks for your quick response.  I will try to explain more clearly below your comment.

On Wednesday, July 28, 2021, 1:12:05 PM MDT, Tom Schuster ***@***.***> wrote:

I honestly still don't understand the problem fully, but I have a theory:  I see that you use your "rss" folder as both the parent of other folders, but also a RSS folder itself? No, the RSS folder was simply an ordinary folder on the Toolbar.  Each rss feed was a separate sub-folder under the "RSS' folder.  This worked as desired for several months, since I initially added the livemarks extension.  Suddenly it stopped working (after a Firefox update I believe).  I tried to fix it by creating a new profile and loading a backup copy of my Firefox bookmarks and then adding Livemarks again.  However when I tried to add 'RSS;' (or any folder on the toolbar for that matter) as the location for my Rss feeds, the toolbar and its sub-menus were no longer visible, i.e. it was not visible/selectable as an option in the menu.    Only the "Bookmarks Menu" and all of its sub-menus were visilble. I hope that is a clearer explanation.  I think there is something about the structure of my Firefox bookmarks that Livemarks doesn't like, but I have no clue as to what, because they seem very ordinary and there is no feedback as to what the problem is, other than Livemarks just not "seeing" the Toolbar folder.  I am very perplexed!

Craig Steury

On Wednesday, July 28, 2021, 1:12:05 PM MDT, Tom Schuster @.***> wrote:

That is not supported and will break thing. You have to change the livemarks that uses the folder for "rss" to   something else. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

evilpie commented 3 years ago

I suggest you start by investigating the getAllBookmarkFolders method. You can also run this from the console and set breakpoint.

csteury commented 3 years ago

Ok, thanks I'll have a look. cs

On Wednesday, July 28, 2021, 2:22:03 PM MDT, Tom Schuster ***@***.***> wrote:  

I suggest you start by investigating the getAllBookmarkFolders method. You can also run this from the console and set breakpoint.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.