search

nt1m / livemarks

Extension that restores RSS Feed Livemarks in Firefox.
https://addons.mozilla.org/firefox/addon/livemarks/
MIT License
231 stars 23 forks source link

livemarks not stored in target folder as per settings, rss feeds not stored separately either #351

Open wallymann opened 3 years ago

wallymann commented 3 years ago

Add-on version Add-on version: 3.3

Describe the bug added feeds and imported feeds are not saved in the correct folder as per the settings.

To Reproduce Steps to reproduce the behavior:

  1. create a bookmarks folder e.g., "Livemarks".
  2. set default RSS folder in livemarks options as the "Livemarks" folder just created in step-1.
  3. import a RSS OPML file (example attached) or subscribe to a new RSS feed.
  4. you will see that the RSS feeds are not in the "Livemarks" folder as per the settings, instead they are all at the root bookmark folder.

Expected behavior all RSS feeds should be stored in the chosen folder e.g., "Livemarks"

Extra context 2021-04-12 09_57_40-Greenshot 2021-04-12 09_57_12-Window feedbro-subscriptions-20210412-093136.opml.txt

evilpie commented 3 years ago

Does this still happen?

wallymann commented 3 years ago

yes...the issue persists, i'm no longer able to effectively use livemarks. any suggestions?

Marakai commented 3 years ago

Adding comment that this is also happening for me with the latest version. Old/pre-existing feed work fine, any new feed added show this behaviour.

evilpie commented 3 years ago

@Marakai do you have any other extension installed?

ghost commented 3 years ago

Same here. Existing feeds work normally, but new feeds have no folder structure. Adding a new feed is not currently a useable function.

Edit: The problem is caused by the Default Bookmark Folder addon. Workaround is to disable DBF, save the feed, and enable DBF again.

ghost commented 3 years ago

Just to clarify, I am not sure whether I have quite the same problem as @wallymann. I am not changing the folder setting in Livemarks, and I am not clear whether @wallymann only has a problem when that default is changed.

The default Firefox folder for bookmarks has changed, though, which is why I use the DBF addon.

evilpie commented 3 years ago

Livemarks is not compatible with the extension "Default Bookmark Folder". The bookmark star in Firefox actually remembers the last selected folder as well.

ghost commented 3 years ago

@evilpie It used to, but now the folder has to be reselected every time - unless that's just for the Linux version. "Default Bookmark Folder" restores the old behaviour, as do other addons :)

Once the feed is saved, there is no problem with Livemarks.

wallymann commented 3 years ago

ok...i do have the DBF add-on...i will test disabling DBF when adding feeds to livemarks

evilpie commented 3 years ago

I don't think that is true, but anyway not important: https://bugzilla.mozilla.org/show_bug.cgi?id=1432604.

Is anyone experience this issue without "Default Bookmark Folder" being installed?

wallymann commented 3 years ago

ok...i tested the "disable DBF, import/add livemarks, re-enable DBF" and it's not really working.

the import appears to work, in that it creates the livemarks in my desired location. see image 1 below.

however, all of the actual RSS updates are just dumped into the root bookmark folder. see image 2 below.

image image

evilpie commented 3 years ago

This is expected. "Default Bookmark Folder" will move all bookmarks created by Livemarks. As I said both extensions are incompatible.