nt1m / livemarks

Extension that restores RSS Feed Livemarks in Firefox.
https://addons.mozilla.org/firefox/addon/livemarks/
MIT License
231 stars 23 forks source link

Bookmark titles getting truncated #451

Closed ali1234 closed 1 year ago

ali1234 commented 1 year ago

Add-on version: 3.5 Firefox version: 113.0.2 (From Snap)

Describe the bug The titles of some bookmarks are being truncated, even though there is plenty of space:

image

To Reproduce Not sure. It seems to happen randomly when the bookmark is reloaded. I have seen those same titles get rendered in full one of previous times this feed refreshed. It seems like it is more likely to happen to the items at the top than at the bottom. I checked the feed and the titles are not truncated there. Also, hovering the mouse over the items shows the full title. So this seems to be some change inside Firefox.

Expected behavior All items should be truncated to the same length. Note this is a regression.

Extra context This may be related to my custom userchrome.css. I'll investigate that possibility next.

ali1234 commented 1 year ago

The livemark reloaded and the problem disappeared even with my customizations on, so I'm not sure what is going on here.

Looking at the screenshot, it looks like the truncated bookmarks have the same length as the first fully shown one following them. Very weird.

Also I never noticed this happening with normal bookmark folders, although I don't use those very often.

nt1m commented 1 year ago

Are the titles truncated in the RSS feed itself?

ali1234 commented 1 year ago

I can't be 100% sure because the feed updates every half an hour so by the time I notice the problem it has already changed. However I think it is unlikely because if the title is truncated in the RSS, then how can Firefox show me the full title when I mouse over? It only gets put into the title attribute and nowhere else in the RSS.

ali1234 commented 1 year ago

Given the pattern in the lengths and the way it disappeared entirely when I reloaded, I would guess that this is somehow related to the order that the folder is populated when the feed changes. Possibly including changes to the title of existing videos, which I noticed happens a lot. Also due to the way I aggregate the data it is possible for new videos to show up in the middle of the list if they were private for a few hours after upload which is also not unusual.

ali1234 commented 1 year ago

I can confirm it is not caused by my userchrome, nor it is a problem with the RSS feed itself. However, the problem can disappear even when the RSS does not change. I am not yet sure why.

ali1234 commented 1 year ago

An update: if I have two browser windows open, it is possible that the truncation differs between them. If I open a new window, the titles are never truncated.

This looks more and more like a Firefox bug to me.

nt1m commented 1 year ago

@Emilio could this be a XUL layout bug?

emilio commented 1 year ago

Unlikely because that is gone :)

How are these rendered?

ali1234 commented 1 year ago

Finally caught it happening with userchrome disabled:

image

Simultaneously, in another window, the same menu looks like this:

image

I also noticed that when this happens, the truncated titles are usually in a browser window that I have not looked at for a while and is minimized, so it could be something like available space not being calculated correctly if there's no windowing context because the window is hidden. (On X11 and Xfwm)

It seems like what is happening is livemarks sees a new item in the feed and adds it at the top, but somehow it retains the width of the bookmark that previously occupied that slot, and sometimes this can happen more than once as in the first screenshot in the original report.

Anyway I think I'll report this on bugzilla tomorrow.

seamusriordan commented 1 year ago

I'm having similar issues. @ali1234 Did you file something on bugzilla?

ali1234 commented 1 year ago

I forgot. But now I did it: https://bugzilla.mozilla.org/show_bug.cgi?id=1848526

nt1m commented 1 year ago

Closing as emilio fixed this in Firefox 121.