nt1m / livemarks

Extension that restores RSS Feed Livemarks in Firefox.
https://addons.mozilla.org/firefox/addon/livemarks/
MIT License
227 stars 22 forks source link

[Request] Additional tag or different icon for rss/feed folders #60

Open Aris-t2 opened 5 years ago

Aris-t2 commented 5 years ago

At the moment there is no visual difference between default bookmark folder icons and a rss/feed folder icons.

Please add a different icon to feed folders or at least an exclusive tag, so the folder can be determined by CSS and manually styled in userChrome.css.

nt1m commented 5 years ago

Bookmark tags are currently not changeable via the WE API. There's currently a bug filed about it: https://bugzilla.mozilla.org/show_bug.cgi?id=1225916

Icons can't be changed either.

I guess the best I can do here is add support for some kind of title prefix for the bookmark folder ?

Aris-t2 commented 5 years ago

Thanks for the answer.

So for now we only can achieve something like this with custom code based on folder label in userChrome.css:

.bookmark-item[label="label_of_feed_folder"] .toolbarbutton-icon {
  list-style-image: url("path_to_icon") !important;
}
GrosBourrin commented 5 years ago

in userChrome.css 👍

bookmarks-view treechildren::-moz-tree-image(container), #PlacesToolbarItems toolbarbutton[container="true"], #PlacesToolbarItems menu[container="true"] .menu-iconic-left, #BMB_bookmarksPopup menu[container="true"] .menu-iconic-icon, #bookmarksMenu menu[container="true"] .menu-iconic-icon, .bookmark-item[container] { list-style-image: url("folder5.svg") !important; / place svg file in the same folder of the css / }

replace folder5.svg by this:

rss2 https://github.com/GrosBourrin/FIREFOX-BLUE-MOON/blob/master/rss%20svg4.svg rss1 https://github.com/GrosBourrin/FIREFOX-BLUE-MOON/blob/master/rss3.svg

right click on link then save target link

you can edit svg files with gravit from gravit.io

Aris-t2 commented 5 years ago

@GrosBourrin Doing this will override all bookmark folders, not just those of rss feeds.

Better to insert rss feed folder names manually to not override other folders like shown in this example:

.bookmark-item[container="true"]:-moz-any([label="rssfeed_name1"],[label="rssfeed_name2"],[label="rssfeed_name3"],[label="rssfeed_name4"]) {
  list-style-image: url("./rss.svg") !important;
  -moz-image-region: rect(0, 16px, 16px, 0) !important;
}
GrosBourrin commented 5 years ago

@Aris-t2 well that's not work with Livemarks addon on Firefox 64.0 !

Aris-t2 commented 5 years ago

I'm using Livemarks 1.14 on Fx 65b7. Livemarks are on my bookmarks toolbar and the labels match those in my code.

1

GrosBourrin commented 5 years ago

i trust you but when i add your code, it doesn't work for me :/ i think i'm loosing something , i share you my userChrome - line 1130 to 1142 on vscode. help me to see what's wrong please. my code is a bit of this and that, catched from some websites adapted bt myself

userChrome.zip

GrosBourrin commented 5 years ago

i trust you but when i add your code after set my lines between /*...*/ of course , it doesn't work for me :/ i think i'm loosing something , i share you my userChrome - line 1130 to 1142 on vscode. help me to see what's wrong please. my code is a bit of this and that, catched from some websites adapted bt myself. I'm on FF 64 x64 on windows 10. they're overiden to do the same at menus and sidepanel icons

userChrome.zip

Aris-t2 commented 5 years ago

You wrote ".bookmarks-item" instead of ".bookmark-item". ;-)

GrosBourrin commented 5 years ago

i know, i fixed that but nothing more

Aris-t2 commented 5 years ago

Only test the code for livemarks without the your other code.

GrosBourrin commented 5 years ago

It works but can't modify the classic folder icons in bookmarks bar. neither in sidebar :/ only the Livemarked ones. i think i have to rewrite the code for that but i don't know how... i lack of skill in css....