search

nt1m / material-framework

[Unmaintained] An easy to use material design based framework.
http://nt1m.github.io/material-framework
MIT License
388 stars 86 forks source link

icon-share no longer works #122

Closed nt1m closed 9 years ago

nt1m commented 9 years ago

@PalmerAL I think it's a regression of #121

PalmerAL commented 9 years ago

I'm thinking that it might be good to go back to the previous icon font and undo #121. In addition, this made all of the icon codes wrong. I'm thinking this is a bug in fontello - the icon codes appear right, but once you add some icons and export the font, all the codes are changed, messing up the font.

kCenk commented 9 years ago

What about using these icons? http://google.github.io/material-design-icons/

PalmerAL commented 9 years ago

@kCenk Those icons are just a set of svg's, not an icon font. They are working on this, though (google/material-design-icons#1), so hopefully this can be used soon.

nt1m commented 9 years ago

@kCenk Yes, this is an icon-font, the choice of icon-fonts is because this format is lighter than including all SVG in separate file. What can be done though is creatling an SVG symlink, but those are only supported by Firefox, and it would take as much time (or more) as updating this icon-font to include all icons.

nt1m commented 9 years ago

Ember-paper ships a pretty rich icon-font : https://github.com/miguelcobain/ember-paper/tree/master/vendor/material-icons

Maybe we can test that out. I also experimented with bootstrap-md's icon font but the quality was terrible.

PalmerAL commented 9 years ago

At this point, it looks like the official google font is coming pretty soon, and its probably better to just wait for that. The ember-paper icons are pretty good, though.

kCenk commented 9 years ago

@PalmerAL Yeah i remember reading that up that there is a font on the way from them :+1: @nt1m But there is a way to use the Material Design Icons with https://icomoon.io :)