search

nt1m / vivaldi-fox

An add-on that aims to add Vivaldi style toolbar colouring to the Firefox UI
https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
201 stars 21 forks source link

VivaldiFox changes firefox ui dark theme #117

Closed lenicyl closed 2 years ago

lenicyl commented 3 years ago

The extension is working great but there is one issue. Whenever i enable the extension it changes firefox's ui theme which is an effect i do not want. I have enabled dark theme in both VivaldiFox options and Firefox's themes, however it still gives me menus that are in light mode

Screenshot 2021-04-30 083301

nt1m commented 3 years ago

There's a theme editor where you can edit the popup properties. Have you tried it?

Q-out commented 3 years ago

Came here to report the same thing. But I'm glad VF is still working on the redesign at least. It's only the popup menus that are light themed.

Switching to any theme in Firefox enables the theme, and applies its colors properly including on the popup menus: image But then switching tabs reverts it to light colors even as it still shows that other theme as applied: image

There's a theme editor where you can edit the popup properties. Have you tried it?

Do you mean https://color.firefox.com? I tried it, the colors from it are instantly overwritten by VF — which is good normally but it means the white popups come back as well.

nt1m commented 3 years ago

There's a theme editor where you can edit the popup properties. Have you tried it?

Do you mean https://color.firefox.com? I tried it, the colors from it are instantly overwritten by VF — which is good normally but it means the white popups come back as well.

Nope, I mean this, go to the add-ons manager and visit the VivaldiFox preferences:

image

It brings you to this page:

image
videopilot commented 3 years ago

It seems to break Firefox's system theme detection and changes. On Mac that affects other dialogs and pop up menus.

systemdark

nt1m commented 3 years ago

yeah this was changed in Firefox 91: https://bugzilla.mozilla.org/show_bug.cgi?id=1715145

The dark theme follows the toolbar background color shade, so you could edit the toolbar background color to be dark?

Though you should file a bug on bugzilla if you don't want to do this, I can't really do anything about this.

Q-out commented 3 years ago

Nope, I mean this, go to the add-ons manager and visit the VivaldiFox preferences:

Ah, I didn't realize editing the popup colours would edit the menu ...popup, which seems obvious now. Thank you, I've got my dark menus with a colourful navbar.