search

nt1m / vivaldi-fox

An add-on that aims to add Vivaldi style toolbar colouring to the Firefox UI
https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
203 stars 22 forks source link

Doesn't work with HSL #61

Closed peiche closed 6 years ago

peiche commented 6 years ago

Theme color is not applied when the color is in HSL. I created a few demo pages:

RGB (works) Hex (works) HSL (doesn't work)

It's worth mentioning that Vivaldi does correctly apply the theme color when it's in HSL.

nt1m commented 6 years ago

Thanks for reporting!

Seems like my color wrapper doesn't handle HSL atm: https://github.com/nt1m/vivaldi-fox/blob/master/background/color.js#L10

I'll see what I can do

nt1m commented 6 years ago

I've fixed this in the latest beta: https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/versions/beta

peiche commented 6 years ago

Installed it and confirmed it working. 👍