search

nt1m / vivaldi-fox

An add-on that aims to add Vivaldi style toolbar colouring to the Firefox UI
https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
201 stars 21 forks source link

Google Inbox shows dark icons instead of white ones #88

Open andreicristianpetcu opened 6 years ago

andreicristianpetcu commented 6 years ago

go to https://inbox.google.com/

screenshot from 2018-06-08 17-43-23

If I use Envify then this is the color it sets for the icons

screenshot from 2018-06-06 10-12-02

I expect the Vivaldifox icons to be white like in Envify.

I'm running Vivaldifox v3.0b1

andreicristianpetcu commented 6 years ago

Chameleon Dynamic Theme is working on a similar issue. Here is the bug report https://github.com/taboca/browser-adaptation-dynamic-theme/issues/14 and the PR https://github.com/taboca/browser-adaptation-dynamic-theme/pull/18/files

nt1m commented 5 years ago

I finally got time to look at this 😅 Thanks for reporting.

Looks like I should maybe use Firefox's algorithm: https://searchfox.org/mozilla-central/source/browser/base/content/contentTheme.js#9-11

Instead of my own custom one: https://github.com/nt1m/vivaldi-fox/blob/2146fd4a00639f3ad331009fb18f002223114dcc/background/color.js#L24-L25

for finding the right color.

nt1m commented 5 years ago

Interesting, Firefox's formula, despite being W3C compliant whereas Envify's isn't, also computes the text color to black.