search

nt1m / vivaldi-fox

An add-on that aims to add Vivaldi style toolbar colouring to the Firefox UI
https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
201 stars 21 forks source link

Black favicons do current tab undistinguishable from inactive tabs #93

Closed Martin1887 closed 6 years ago

Martin1887 commented 6 years ago

When the current active tab has a black favicon, it is really difficult knowing which is the active tab.

It could be resolved putting bold the current tab title or making semitransparent the inactive tabs, but in order to not do less readable the inactive tabs maybe this only should be applied on black active tabs.

Another solution would be changing the absolute black for another color when the active tab is black.

Thanks.

nt1m commented 6 years ago

@Martin1887 Have you tried the "Enable white background" setting for icons ? This way the icon is always visible.

Martin1887 commented 6 years ago

I have tried it but it does nothing. I'm using Fedora 28 with Cinnamon 3.8.8.

But it happens to me at work in Windows 10 I think. I will test it tomorrow.

nt1m commented 6 years ago

@Martin1887 The setting doesn't apply to tabs that already exist when you change the setting, it only applies to future tabs you load.

Martin1887 commented 6 years ago

GitHub is a good example of this issue.

I have tried to open another GitHub tab with this option enabled and it has not worked.

I will remain it enabled and I will close the issue if it works.

Martin1887 commented 6 years ago

I have tried the option without success.

The GitHub tabs remain black and other sites that were well colored got worse (for instance, the color of Gmail is uglier and the favicon becomes white in some parts making it also uglier).

In conclusion, that option is not a valid workaround for me, although I understand that other issues can have more priority than this one.

Martin1887 commented 6 years ago

The new tab line color option fix the issue.