search

ntadmin / DGND3700v2

Custom firmware for the Netgear DGND3700v2
12 stars 4 forks source link

Ensure that updated busybox top works. #19

Closed ntadmin closed 8 years ago

ntadmin commented 8 years ago

Diff for top.c

    203c203
    <       if (ret >= 4) {
    ---
    >       if (ret > 4) {

The code in question (original) is:

        if (ret >= 4) {
                p_jif->total = p_jif->usr + p_jif->nic + p_jif->sys + p_jif->idle
                        + p_jif->iowait + p_jif->irq + p_jif->softirq + p_jif->steal;
                /* procps 2.x does not count iowait as busy time */
                p_jif->busy = p_jif->total - p_jif->idle - p_jif->iowait;
        }

The only reason for this would be if, on the DGND, p_jif->iowait can't be trusted if it isn't scanned. The code seems unchanged in the latest version (here).

So, open question: how important is this change?

ntadmin commented 8 years ago

top works out of the box, at least from a 'run it and the screen fills with the processes' perspective. It may be that there is an error in the jiffies, but I am unable to ascertain this. Closing this issue, if someone can identify an issue and show how to test it we will re-create with a different milestone.