ntadmin / DGND3700v2

Custom firmware for the Netgear DGND3700v2
12 stars 4 forks source link

Ensure that wget works with new busybox #21

Closed ntadmin closed 8 years ago

ntadmin commented 8 years ago

Diff (Netgear vs original 1.13.4):

536c536,538
<       lsa = xhost2sockaddr(server.host, server.port);

---
> /*    gordon modify it to let device just use ipv4 when wget command is called */
> //    lsa = xhost2sockaddr(server.host, server.port);
>       lsa = xhost_and_af2sockaddr(server.host, server.port, AF_INET);
680c682,684
<                                               lsa = xhost2sockaddr(server.host, server.port);

---
> /*    gordon modify it to let device just use ipv4 when wget command is called */
> //                                            lsa = xhost2sockaddr(server.host, server.port);
>                                               lsa = xhost_and_af2sockaddr(server.host, server.port, AF_INET);
ntadmin commented 8 years ago

This looks like it is simply constraining wget to only use ipv4. Whilst this is fine, not sure what the gain is (a bit of time?). Possibly this is needed if you are using the netgear auto-update system. But if you are using our firmware, you wouldn't want to use that anyway, so we can roll with this code change being dropped until we have evidence otherwise.