ntadmin / DGND3700v2

Custom firmware for the Netgear DGND3700v2
12 stars 4 forks source link

Ensure that libbb is ok in new version of busybox #25

Closed ntadmin closed 8 years ago

ntadmin commented 8 years ago

Two affected files:

busybox-1.13/libbb/bb_askpass.c
busybox-1.13/libbb/correct_password.c
ntadmin commented 8 years ago

Diff for askpass:

57a58,59
>       if(passwd[0]=='\n' || passwd[0]=='\r')
>               read(STDIN_FILENO, passwd, sizeof_passwd-1);

Diff for correct_password:

74a75,76
> #define SC_HACK
> #ifndef SC_HACK
79c81,84
<       return r;
---
> #else
>     r = (strcmp(unencrypted, correct) == 0);
> #endif
>     return r;
ntadmin commented 8 years ago

correct_password: This code seems to alter the busybox code to check passwords in plain text rather than using the pw_ecncrypt options. Like, why? Anyway, we have ssh working and telnet working as far as we can tell, so I think we'll lose this Netgear feature. If someone finds a reason to re-=instate it, let's create an issue to change things so that we don't need plain text passwords!

ntadmin commented 8 years ago

askpass: This line is added so that if you enter a blank password, it asks again. But only once. Losing these lines are a good thing.

ntadmin commented 8 years ago

On the basis of the above two comments, this is closed.