toddbranch
commented
10 years ago Prelab - 10
Required - 50 - 5 (1 day late) = 45 A - 10 - 1 (1 day late) = 9 Bonus - 0
Use of Git - Check Minus - 3 - Make sure the commits are descriptive of all the code your committing. "all code here just restructuring" and "all code complete searching for errors" are not helpful. Tell me the errors you're seeing and how you fixed them! Tell me what you're restructuring! Code Style - Check - 4 - Generally good code structure. Replace magic numbers with constants or generics. Add short, relevant headers. Be careful with processes:
-- state_next matters here, so it should be in your sensitivity list!
process(count_reg, state_reg)
begin
if(state_reg /= state_next) then
count_next <= "00000000000";
else
count_next <= count_reg + "00000000001" ;
end if;
end process; -- why is h_completed in your sensitivity list if you don't use it?
process(state_next, count_next, h_completed)
begin
v_sync <= '1';
blank <= '1';
completed <= '0';
row <= (others => '0');
case state_reg is
when active_video=>
row <= count_next;
blank <= '0';
when front_porch=>
when sync_pulse=>
v_sync <= '0';
when back_porch=>
when completed_state=>
completed <= '1';
end case;
end process;README - Check - 17 - Great pictures and code blocks. But I need more detail about the problem your FSM is trying to solve - achieving the timing requirements of VGA! Once you know that, you can tell me the hardware structure of an FSM and the code constructs you used to realize it. I'm distracted by all the entity code you're showing me! Show specific examples of how you created DFF, next state logic, etc. I really like the testbench picture in test / debug - next time use it to show me errors you ran into!
Total - 88
Prelab = 10/10 Required = 45/50 b/c less than 1 day late A = 9/10 b/c less than 1 day late