nteract / bookstore

📚 Notebook storage and publishing workflows for the masses
https://bookstore.readthedocs.io
BSD 3-Clause "New" or "Revised" License
202 stars 23 forks source link

Increase test coverage #118

Closed willingc closed 5 years ago

willingc commented 5 years ago

PR #117 adds display of test coverage as a badge in the README, on every Python 3.6 travis run and on local test runs using tox.

Let's work on increasing coverage on these files (in priority order):

This will get us closer to our release benchmark in #96.

willingc commented 5 years ago

127 adds tests to reach 100% file coverage of s3_paths.py

willingc commented 5 years ago

128 adds a few tests for archive and a test stub file for publish.

@mpacer @MSeal @rgbkrk After these land we should be at approx 49% coverage.

willingc commented 5 years ago

Now @mpacer's latest PR pushes us to high 60s. Woo! 👍

mpacer commented 5 years ago

We landed on 79% by the time of release — it feels pretty darn good.

Closing!