search

nteract / bookstore

📚 Notebook storage and publishing workflows for the masses
https://bookstore.readthedocs.io
BSD 3-Clause "New" or "Revised" License
202 stars 23 forks source link

determine if extract kernel id is used more than once #119

Closed todo[bot] closed 5 years ago

todo[bot] commented 5 years ago

https://github.com/nteract/bookstore/blob/990ec7df787e390a3ab83625d6f39c15194cd962/bookstore/client/nb_client.py#L222-L223

This issue was generated by todo based on a TODO comment in 990ec7df787e390a3ab83625d6f39c15194cd962 when #90 was merged. cc @willingc.
mpacer commented 5 years ago

It is not currently in use more than once, but I want it to be overwritable in the situation where a there is a different scheme for defining the connection file name (which I've seen come up in a couple of cases… though they are escaping me right now).

willingc commented 5 years ago

Sounds reasonable. I'll open a PR to remove the todo.