Closed mpacer closed 5 years ago
TODO
comment in aa4e1e3660d268a931e1dab3bd2d760c3c246447 in #130. cc @mpacer.TODO
comment in e1d393bc332208a7706581bc9069179e9aa9edbc in #130. cc @mpacer.Merging #130 into master will increase coverage by
0.82%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 47.32% 48.14% +0.82%
==========================================
Files 11 11
Lines 374 378 +4
==========================================
+ Hits 177 182 +5
+ Misses 197 196 -1
Merging #130 into master will increase coverage by
0.43%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 79.14% 79.57% +0.43%
==========================================
Files 10 10
Lines 422 426 +4
==========================================
+ Hits 334 339 +5
+ Misses 88 87 -1
TODO
comment in 1489aecd511e4bf7b415f9f70a9b46747d9c68bd in #130. cc @mpacer.Hi @MSeal @willingc I made the changes to the API that you suggested as part of this PR now.
this has been rebased on master & is ready for the next round of reviews.
@willingc I'm sorry I missed your comment about changing the name of the top level property of the API response from "validation" to "features" — I just caught it and made the change
I don't see any outstanding issues in this PR so I am going to merge. Thanks @mpacer 🌻
Thanks!
This refactors a bit of the data manipulation code in the handlers into individually testable utils.
This adds tests for the BookstoreVersionHandler.
There are a lot of issues that became obvious as I wrote these tests & helper utils. I will create separate issues for them, but I wanted to list them here.
handlers.py
module, into it's own module."bookstore": True
bit in the response from the BookstoreVersionHandler