Closed mpacer closed 5 years ago
I'd like to move the code that defines which handlers are to be added into the respective modules as well (clone & publish). But I figured this is already touching enough files that it might be a lot to review.
Merging #134 into master will increase coverage by
2.93%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 47.32% 50.25% +2.93%
==========================================
Files 11 11
Lines 374 386 +12
==========================================
+ Hits 177 194 +17
+ Misses 197 192 -5
Merging #134 into master will increase coverage by
2.93%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 47.32% 50.25% +2.93%
==========================================
Files 11 11
Lines 374 386 +12
==========================================
+ Hits 177 194 +17
+ Misses 197 192 -5
Feel free to merge @mpacer.
Grazie! @willingc, I made the followup changes after merging your suggestions. Is there anything more that this needs before we can merge it?
Definitely didn't forget to change the method name everywhere causing the handlers to never be added to the web_app & all integration tests to fail… nope definitely wouldn't have done that. ;)
Alright, merging!
The biggest win in this is that this tests which endpoints & handlers are actually enabled in the handlers module. #130 does not address this, and should probably be rebased on top of this if this is merged.
BookstoreSettings.cloning_enabled
traitletcloning_enabled
to validation codebuild_handlers
function so we can test it directly (allowing less mocking)publish_enabled
andarchive_enabled
pytest
requirement to includepytest>=3.6
(as required bypytest-asyncio
as reported in this issue)