nteract / bookstore

📚 Notebook storage and publishing workflows for the masses
https://bookstore.readthedocs.io
BSD 3-Clause "New" or "Revised" License
201 stars 23 forks source link

Add "id" back to NotebookSession class #135

Open mpacer opened 5 years ago

mpacer commented 5 years ago

Currently we are consuming the id passed through via the sessions response http://jupyter-api.surge.sh/#!/sessions/get_api_sessions_session in the nb_client library and not setting it to a variable. My guess is that this was removed earlier because of similar issues to those raised around keeping the kernel's "id" field.

I discovered this as I was writing unit tests for the client section; I am going to refrain from adding it in those tests, but will leave commented code in place to indicate the functionality's future return (mostly for the sake of future integration tests).