nteract / bookstore

📚 Notebook storage and publishing workflows for the masses

https://bookstore.readthedocs.io

BSD 3-Clause "New" or "Revised" License

201 stars 23 forks source link

Archive test improvements #138

Closed mpacer closed 5 years ago

mpacer commented 5 years ago

From my perspective, the most important thing this PR does is to add a test to ensure that we test the code path where we skip archiving based on a lock having been already acquired.

codecov[bot] commented 5 years ago

Codecov Report

Merging #138 into master will increase coverage by 1.51%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage    68.6%   70.12%   +1.51%     
==========================================
  Files          10       10              
  Lines         395      395              
==========================================
+ Hits          271      277       +6     
+ Misses        124      118       -6

codecov[bot] commented 5 years ago

Codecov Report

Merging #138 into master will increase coverage by 5.69%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #138      +/-   ##
=========================================
+ Coverage    68.6%   74.3%   +5.69%     
=========================================
  Files          10      10              
  Lines         395     432      +37     
=========================================
+ Hits          271     321      +50     
+ Misses        124     111      -13

mpacer commented 5 years ago

@rgbkrk do you have any remaining concerns?

mpacer commented 5 years ago

These tests are sweet.

I know! The caplog fixture is totally changing how I think about tests.